vigneshio commented on code in PR #4620:
URL: https://github.com/apache/polaris/pull/4620#discussion_r3382660432
##########
runtime/service/src/main/java/org/apache/polaris/service/auth/internal/broker/JwtSigningKey.java:
##########
@@ -19,25 +19,16 @@
package org.apache.polaris.service.auth.internal.broker;
import com.auth0.jwt.algorithms.Algorithm;
-import java.util.function.Supplier;
-import org.apache.polaris.core.PolarisCallContext;
-import org.apache.polaris.core.persistence.PolarisMetaStoreManager;
+import com.auth0.jwt.interfaces.JWTVerifier;
-/** Generates a JWT using a Symmetric Key. */
-public class SymmetricKeyJWTBroker extends JWTBroker {
- private final Supplier<String> secretSupplier;
-
- public SymmetricKeyJWTBroker(
- PolarisMetaStoreManager metaStoreManager,
- PolarisCallContext polarisCallContext,
- int maxTokenGenerationInSeconds,
- Supplier<String> secretSupplier) {
- super(metaStoreManager, polarisCallContext, maxTokenGenerationInSeconds);
- this.secretSupplier = secretSupplier;
- }
+/**
+ * Holds the JWT {@link Algorithm} and its derived {@link JWTVerifier} for a
realm. Built once per
+ * realm by a {@link TokenBrokerFactory} and shared across request-scoped
{@link JWTBroker}
+ * instances so the verifier is not reconstructed on every request.
+ */
+record JwtSigningKey(Algorithm algorithm, JWTVerifier verifier) {
Review Comment:
Renamed to AlgorithmAndVerifier. @adutra
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
