dimas-b commented on code in PR #4640:
URL: https://github.com/apache/polaris/pull/4640#discussion_r3377292629


##########
runtime/service/src/test/java/org/apache/polaris/service/config/DefaultConfigurationStoreTest.java:
##########
@@ -199,4 +199,15 @@ public void testRegisterAndUseFeatureConfigurations() {
     Assertions.assertThat(configurationStore.getConfiguration(realmContext, 
catalog, safeConfig))
         .isTrue();
   }
+
+  @Test
+  public void testInvalidFeatureConfigurationIsHandled() {
+    // invalid feature key format (simulates malformed configuration input)
+    String invalidKey = "polaris.features.invalid..json";

Review Comment:
   Do you have reasons to believe some special chars in the key can cause 
config look up errors?
   
   As far as I can tell `DefaultConfigurationStore` does not attempt parsing 
key in any way 🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to