hemasrishalini commented on code in PR #4640:
URL: https://github.com/apache/polaris/pull/4640#discussion_r3407566997
##########
runtime/service/src/test/java/org/apache/polaris/service/config/DefaultConfigurationStoreTest.java:
##########
@@ -199,4 +199,15 @@ public void testRegisterAndUseFeatureConfigurations() {
Assertions.assertThat(configurationStore.getConfiguration(realmContext,
catalog, safeConfig))
.isTrue();
}
+
+ @Test
+ public void testInvalidFeatureConfigurationIsHandled() {
+ // invalid feature key format (simulates malformed configuration input)
+ String invalidKey = "polaris.features.invalid..json";
Review Comment:
Thanks for reviewing.
You're right. Looking at the code again, this test only verifies lookup
behavior for an unknown key and doesn't actually exercise a JSON parsing
failure path.
I opened issue https://github.com/apache/polaris/issues/4639 based on what I
thought was missing test coverage, but I may have misunderstood the actual code
path here.
Would you recommend a more appropriate configuration/parsing path to test,
or should I close this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
