hemasrishalini commented on PR #4640: URL: https://github.com/apache/polaris/pull/4640#issuecomment-4657366200
Thanks for reviewing. You're right. Looking at the code again, this test only verifies lookup behavior for an unknown key and doesn't actually exercise a JSON parsing failure path. I opened issue #4639 based on what I thought was missing test coverage, but I may have misunderstood the actual code path here. Would you recommend a more appropriate configuration/parsing path to test, or should I close this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
