dimas-b commented on code in PR #4659:
URL: https://github.com/apache/polaris/pull/4659#discussion_r3397964431
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java:
##########
@@ -416,30 +431,43 @@ public ListTablesResponse listTables(Namespace namespace)
{
}
/**
- * Create a table.
+ * Convenience entry point used by tests that exercise the authorization
wiring without going
+ * through the REST adapter. Production callers go through the four-arg
overload via the adapter.
*
* @param namespace the namespace to create the table in
* @param request the table creation request
* @return ETagged {@link LoadTableResponse} to uniquely identify the table
metadata
*/
+ @VisibleForTesting
public LoadTableResponse createTableDirect(Namespace namespace,
CreateTableRequest request) {
return createTableDirect(
- namespace, request, EnumSet.noneOf(AccessDelegationMode.class),
Optional.empty());
+ namespace,
+ request,
+ EnumSet.noneOf(AccessDelegationMode.class),
+ Optional.empty(),
+ Optional.empty());
}
/**
- * Create a table.
+ * Convenience entry point used by tests for the write-delegation variant.
Production callers go
+ * through the adapter, which resolves the delegation modes and
refresh-credentials endpoint from
+ * the request.
*
* @param namespace the namespace to create the table in
* @param request the table creation request
* @return ETagged {@link LoadTableResponse} to uniquely identify the table
metadata
*/
+ @VisibleForTesting
public LoadTableResponse createTableDirectWithWriteDelegation(
Review Comment:
#4709
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
