dimas-b commented on code in PR #4115:
URL: https://github.com/apache/polaris/pull/4115#discussion_r3429996140
##########
runtime/service/build.gradle.kts:
##########
@@ -30,9 +30,12 @@ dependencies {
implementation(project(":polaris-api-management-service"))
implementation(project(":polaris-api-iceberg-service"))
implementation(project(":polaris-api-catalog-service"))
+ // compileOnly — MetricsReportsService implements PolarisCatalogsApiService
from this module but
+ // we keep it off the transitive dep graph; runtime/server adds it to the
runtime classpath.
Review Comment:
Well, in this case for completely clean module separation, I'd think we
ought to introduce `extensions/metrics-reports/rest` and move this class there.
Moving it to `extensions/metrics-reports/impl` would be fine too, but that
might later conflate the REST layer with the JDBC impl.
Actually WDYT about renaming current `extensions/metrics-reports/impl` to
`extensions/metrics-reports/base`. It will contain the REST API service class
and the two trivial implementations (log + no-op).
Later, a JDBC impl. would go to `extensions/metrics-reports/jdbc`. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
