dimas-b commented on code in PR #4115: URL: https://github.com/apache/polaris/pull/4115#discussion_r3463496402
########## polaris-core/src/main/java/org/apache/polaris/core/metrics/IcebergMetricsReporter.java: ########## @@ -16,38 +16,33 @@ * specific language governing permissions and limitations * under the License. */ -package org.apache.polaris.service.reporting; +package org.apache.polaris.core.metrics; Review Comment: This interface is not used by `polaris-core` classes, therefore it is _not_ a core SPI. It should not be in `polaris-core`. @flyingImer : I guess this move was made at your suggestion. However, I do believe the previous state of this PR was more coherent and more maintainable in the future. I suggest going back to the version I approved on Jun 18 (at least as far as major module structure is concerned). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
