obelix74 commented on code in PR #4115:
URL: https://github.com/apache/polaris/pull/4115#discussion_r3431903743
##########
extensions/metrics-reports/spi/src/main/java/org/apache/polaris/extension/metrics/IcebergMetricsReporter.java:
##########
@@ -16,38 +16,33 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.polaris.service.reporting;
+package org.apache.polaris.extension.metrics;
Review Comment:
Done — moved to `org.apache.polaris.extension.metrics.spi` (commit
9f0bcde85). Updated all import sites.
##########
runtime/defaults/src/main/resources/application-it.properties:
##########
@@ -20,6 +20,8 @@
# Configuration common to ALL integration tests (executed with "it" profile –
Gradle "intTest" tasks).
# Note: Quarkus integration tests cannot use QuarkusTestProfile.
+polaris.iceberg-metrics.reporting.type=no-op
Review Comment:
Removed — it was redundant with `application-test.properties` (commit
9f0bcde85).
##########
runtime/server/build.gradle.kts:
##########
@@ -40,6 +40,8 @@ dependencies {
runtimeOnly(project(":polaris-extensions-federation-hadoop"))
runtimeOnly(project(":polaris-extensions-auth-opa"))
runtimeOnly(project(":polaris-extensions-auth-ranger"))
+ runtimeOnly(project(":polaris-extensions-metrics-reports"))
+ runtimeOnly(project(":polaris-api-metrics-reports-service"))
Review Comment:
Removed from `runtime/server` — it now flows transitively via
`polaris-extensions-metrics-reports` (commit 9f0bcde85).
##########
runtime/service/src/main/java/org/apache/polaris/service/reporting/MetricsReportingConfiguration.java:
##########
@@ -23,6 +23,6 @@
@ConfigMapping(prefix = "polaris.iceberg-metrics.reporting")
public interface MetricsReportingConfiguration {
- @WithDefault("default")
Review Comment:
Done — added a `DefaultMetricsReporter` static inner class in
`LoggingMetricsReporter` annotated `@Identifier("default")` that extends
`LoggingMetricsReporter`, preserving backward compat (commit 9f0bcde85).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
