adutra commented on code in PR #4812:
URL: https://github.com/apache/polaris/pull/4812#discussion_r3443644283


##########
CHANGELOG.md:
##########
@@ -28,6 +28,7 @@ request adding CHANGELOG notes for breaking (!) changes and 
possibly other secti
 ## [Unreleased]
 
 ### Highlights
+- Polaris now supports dynamic datasource activation. Out of the box, two 
datasources are provided: `postgresql` and `h2`. The datasource to use can be 
selected at runtime by setting the 
`polaris.persistence.relational.jdbc.datasource` configuration property (the 
default is `postgresql`). This allows operators to switch between supported 
relational databases without rebuilding Polaris.

Review Comment:
   Hmm actually the Helm chart _is_ affected – but the admin tool isn't (H2 is 
not available there). Let me rephrase this sentence.
   
   Re: breaking change: the inclusion of a new artifact is not a breaking 
change, is it? Imho this PR is not a breaking change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to