dimas-b commented on code in PR #4812:
URL: https://github.com/apache/polaris/pull/4812#discussion_r3443731489


##########
CHANGELOG.md:
##########
@@ -42,6 +44,7 @@ request adding CHANGELOG notes for breaking (!) changes and 
possibly other secti
     - Names containing control (invisible) characters
     - Names with leading or trailing whitespace
     - Names containing any of these characters: <code>/\:*?"<>|#+`</code>
+- Due to the introduction of dynamic datasource activation, the default 
(PostgreSQL) datasource is now unused. If you had any custom configuration for 
that datasource, it should be migrated from `quarkus.datasource.*` to 
`quarkus.datasource.postgresql.*`. The same is valid for environment variables: 
`QUARKUS_DATASOURCE_*` should be replaced with 
`QUARKUS_DATASOURCE_POSTGRESQL_*`.

Review Comment:
   This is a reasonable notice to users, IMHO... However, given that the 1.6.0 
release is supposed to happen pretty soon, should we defer merging this PR 
until after 1.6.0 is branched?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to