venkateshwaracholan commented on PR #4770:
URL: https://github.com/apache/polaris/pull/4770#issuecomment-4844448130

   @MonkeyCanCode Thanks for taking another look!
   
   I've addressed both comments:
   
   * Removed the `_load_profiles()` / `_save_profiles()` wrappers since they 
were just pass-through methods after the refactor, so calling `load_profiles()` 
/ `save_profiles()` directly keeps things simpler.
   * Simplified the secret display logic so any profile with a `client_secret` 
field now always displays `MASKED_CLIENT_SECRET`, regardless of the stored 
value. I also updated the associated tests to reflect this behavior.
   
   Thanks again for the feedback!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to