MonkeyCanCode commented on code in PR #4770:
URL: https://github.com/apache/polaris/pull/4770#discussion_r3457048482
##########
client/python/apache_polaris/cli/command/profiles.py:
##########
@@ -56,16 +56,10 @@ class ProfilesCommand(Command):
profile_name: Optional[str] = None
def _load_profiles(self) -> Dict[str, Dict[str, Any]]:
Review Comment:
as now the _load_profiles and _save_profiles are direct wrapper on top of
load_profiles and save_profiles, do we still need the helper function here?
##########
client/python/apache_polaris/cli/profile_config.py:
##########
@@ -0,0 +1,70 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+import json
+import os
+import tempfile
+from typing import Any, Dict, Optional
+
+from apache_polaris.cli.constants import CONFIG_DIR, CONFIG_FILE
+
+CONFIG_FILE_MODE = 0o600
+MASKED_CLIENT_SECRET = "********"
+
+
+def mask_client_secret(client_secret: Optional[str]) -> Optional[str]:
Review Comment:
wondering why do we want to do a check here? should we not just blindly use
MASKED_CLIENT_SECRET here regardless the value of client_secret?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
