venkateshwaracholan commented on PR #4770: URL: https://github.com/apache/polaris/pull/4770#issuecomment-4770529261
@MonkeyCanCode Thanks for the review. - Switched `str | None` to `Optional[str]` for consistency with the existing codebase. - Removed the redundant `ensure_config_file_permissions()` call after `os.replace()`, since the file permissions are already set on the temporary file before replacement. - Updated the related tests accordingly. Thanks for taking another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
