Copilot commented on code in PR #4966:
URL: https://github.com/apache/polaris/pull/4966#discussion_r3521998459
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -305,6 +305,8 @@ public static void enforceFeatureEnabledOrThrow(
public static final FeatureConfiguration<Boolean>
ALLOW_EXTERNAL_METADATA_FILE_LOCATION =
PolarisConfiguration.<Boolean>builder()
.key("ALLOW_EXTERNAL_METADATA_FILE_LOCATION")
+
.catalogConfig("polaris.config.allow.external.metadata.file.location")
+ .legacyCatalogConfig("allow.external.metadata.file.location")
.description(
Review Comment:
This change makes ALLOW_EXTERNAL_METADATA_FILE_LOCATION overridable via
catalog properties, but the feature-flag documentation currently lacks a
corresponding “Catalog Config” entry for this flag (unlike similar flags).
Please check whether the config-doc generation (or the docs source) needs to be
regenerated/updated so the new catalog-level keys are documented (e.g.,
site/content/in-dev/unreleased/configuration/config-sections/flags-polaris_features.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
