dimas-b commented on code in PR #4966:
URL: https://github.com/apache/polaris/pull/4966#discussion_r3532869578
##########
runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/AbstractLocalIcebergCatalogTest.java:
##########
@@ -1316,15 +1306,10 @@ public void
testUpdateNotificationCreateTableInExternalLocation() {
final String anotherTableLocation =
String.format("s3://my-bucket/path/to/data/another_table_%s/",
tableSuffix);
- metaStoreManager.updateEntityPropertiesIfNotChanged(
- polarisContext,
- List.of(PolarisEntity.toCore(catalogEntity)),
- new CatalogEntity.Builder(CatalogEntity.of(catalogEntity))
- .addProperty(
-
FeatureConfiguration.ALLOW_EXTERNAL_TABLE_LOCATION.catalogConfig(), "false")
- .addProperty(
-
FeatureConfiguration.ALLOW_UNSTRUCTURED_TABLE_LOCATION.catalogConfig(), "true")
- .build());
+ updateCatalogProperties(
+ Map.of(
+
FeatureConfiguration.ALLOW_EXTERNAL_TABLE_LOCATION.catalogConfig(), "false",
+
FeatureConfiguration.ALLOW_UNSTRUCTURED_TABLE_LOCATION.catalogConfig(),
"true"));
Review Comment:
Same: setting `ALLOW_EXTERNAL_METADATA_FILE_LOCATION` does not see to be
necessary here. The test passed without it in my env. 🤔
I wonder about other cases of putting
`ALLOW_EXTERNAL_METADATA_FILE_LOCATION` into catalog properties. The settings
were present before, but because they were not loaded from catalog properties
before this PR, they are probably useless... WDYT?
##########
runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/AbstractLocalIcebergCatalogTest.java:
##########
@@ -2790,7 +2775,8 @@ public void
testUpdatePropertiesRejectsOutOfTableWriteMetadataLocation() {
updateCatalogProperties(
Map.of(
FeatureConfiguration.ALLOW_EXTERNAL_TABLE_LOCATION.catalogConfig(), "false",
-
FeatureConfiguration.ALLOW_UNSTRUCTURED_TABLE_LOCATION.catalogConfig(),
"true"));
+
FeatureConfiguration.ALLOW_UNSTRUCTURED_TABLE_LOCATION.catalogConfig(), "true",
+
FeatureConfiguration.ALLOW_EXTERNAL_METADATA_FILE_LOCATION.catalogConfig(),
"false"));
Review Comment:
Setting `ALLOW_EXTERNAL_METADATA_FILE_LOCATION` does not see to be necessary
here. The test passed without it in my env. 🤔
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -305,6 +305,8 @@ public static void enforceFeatureEnabledOrThrow(
public static final FeatureConfiguration<Boolean>
ALLOW_EXTERNAL_METADATA_FILE_LOCATION =
PolarisConfiguration.<Boolean>builder()
.key("ALLOW_EXTERNAL_METADATA_FILE_LOCATION")
+
.catalogConfig("polaris.config.allow.external.metadata.file.location")
+ .legacyCatalogConfig("allow.external.metadata.file.location")
Review Comment:
"legacy" names are probably not necessary for new properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
