dimas-b commented on code in PR #4966:
URL: https://github.com/apache/polaris/pull/4966#discussion_r3539711767
##########
runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/AbstractLocalIcebergCatalogTest.java:
##########
@@ -1316,15 +1306,10 @@ public void
testUpdateNotificationCreateTableInExternalLocation() {
final String anotherTableLocation =
String.format("s3://my-bucket/path/to/data/another_table_%s/",
tableSuffix);
- metaStoreManager.updateEntityPropertiesIfNotChanged(
- polarisContext,
- List.of(PolarisEntity.toCore(catalogEntity)),
- new CatalogEntity.Builder(CatalogEntity.of(catalogEntity))
- .addProperty(
-
FeatureConfiguration.ALLOW_EXTERNAL_TABLE_LOCATION.catalogConfig(), "false")
- .addProperty(
-
FeatureConfiguration.ALLOW_UNSTRUCTURED_TABLE_LOCATION.catalogConfig(), "true")
- .build());
+ updateCatalogProperties(
+ Map.of(
+
FeatureConfiguration.ALLOW_EXTERNAL_TABLE_LOCATION.catalogConfig(), "false",
+
FeatureConfiguration.ALLOW_UNSTRUCTURED_TABLE_LOCATION.catalogConfig(),
"true"));
Review Comment:
However, since it's not affected by the main change in this PR, let's keep
it (maybe remove later).
##########
runtime/service/src/test/java/org/apache/polaris/service/catalog/iceberg/AbstractLocalIcebergCatalogTest.java:
##########
@@ -2790,7 +2775,8 @@ public void
testUpdatePropertiesRejectsOutOfTableWriteMetadataLocation() {
updateCatalogProperties(
Map.of(
FeatureConfiguration.ALLOW_EXTERNAL_TABLE_LOCATION.catalogConfig(), "false",
-
FeatureConfiguration.ALLOW_UNSTRUCTURED_TABLE_LOCATION.catalogConfig(),
"true"));
+
FeatureConfiguration.ALLOW_UNSTRUCTURED_TABLE_LOCATION.catalogConfig(), "true",
+
FeatureConfiguration.ALLOW_EXTERNAL_METADATA_FILE_LOCATION.catalogConfig(),
"false"));
Review Comment:
Setting `ALLOW_EXTERNAL_METADATA_FILE_LOCATION` does not seem to be
necessary here. The test passed without it in my env. 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
