nandorKollar commented on code in PR #4970:
URL: https://github.com/apache/polaris/pull/4970#discussion_r3536344235
##########
runtime/service/src/main/java/org/apache/polaris/service/task/TableCleanupTaskHandler.java:
##########
@@ -246,7 +246,8 @@ private Stream<TaskEntity> getMetadataTaskStream(
PolarisMetaStoreManager metaStoreManager,
CallContext callContext) {
PolarisCallContext polarisCallContext =
callContext.getPolarisCallContext();
- int batchSize =
callContext.getRealmConfig().getConfig(TABLE_METADATA_CLEANUP_BATCH_SIZE);
Review Comment:
I'm wondering that instead of setting batch size to 1 in case an invalid
value is supplied, shouldn't we validate the value of this configuration, and
fail with a clear error message? What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
