ayushtkn commented on code in PR #4970:
URL: https://github.com/apache/polaris/pull/4970#discussion_r3541480074
##########
runtime/service/src/main/java/org/apache/polaris/service/task/TableCleanupTaskHandler.java:
##########
@@ -246,7 +246,8 @@ private Stream<TaskEntity> getMetadataTaskStream(
PolarisMetaStoreManager metaStoreManager,
CallContext callContext) {
PolarisCallContext polarisCallContext =
callContext.getPolarisCallContext();
- int batchSize =
callContext.getRealmConfig().getConfig(TABLE_METADATA_CLEANUP_BATCH_SIZE);
Review Comment:
I believe we should atleast log it. If someone accidentally puts `-10`
instead of `10`, there should be some log line telling it was a wrong value and
we are using `1`.
Not sure, but if that is an invalid value, we could have fallen back to the
`default` value as well rather than choosing `1`. Hadoop kind of behaviour
https://github.com/apache/hadoop/blob/85c233724020e27ca9e5ef69fec2fe6de1d592a1/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DirectoryScanner.java#L316-L321
But this is also ok :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
