dimas-b commented on code in PR #4970:
URL: https://github.com/apache/polaris/pull/4970#discussion_r3537040875
##########
runtime/service/src/main/java/org/apache/polaris/service/task/TableCleanupTaskHandler.java:
##########
@@ -246,7 +246,8 @@ private Stream<TaskEntity> getMetadataTaskStream(
PolarisMetaStoreManager metaStoreManager,
CallContext callContext) {
PolarisCallContext polarisCallContext =
callContext.getPolarisCallContext();
- int batchSize =
callContext.getRealmConfig().getConfig(TABLE_METADATA_CLEANUP_BATCH_SIZE);
Review Comment:
I was thinking about validation, but it does not look like we have that
capability at the RealmConfig level. I think it would be good to add, though.
With current code, we can only fail individual tasks that try to use the
invalid value, but those failures will be hard to discover (async logs). I'd
prefer current approach at least until we have user-friendly realm config
validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
