sebbASF commented on pull request #517: URL: https://github.com/apache/incubator-ponymail/pull/517#issuecomment-691469821
Well of course the id should be as short as possible -- but no shorter. The current dkim_id ignores the lid, so I think the generated hash is not guaranteed unique (not all lists have list-id headers). So either the lid needs to be separately appended as I suggest, or the lid must be added to the hash input as was done in a previous version of the PR. However I think including the lid in the hash input would be a mistake. I don't believe it's feasible to recover a message from an id that includes the lid as part of the hash, even if one has all the original archives readily available. It would mean processing all the messages with all possible lids, considerably increasing the workload. Whereas with an independent lid, not only would it not be necessary to try all possible lids, it would only be necessary to try the archives for the relevant list. == It occurs to me that the lid suffix can be shortened for a particular installation if it only serves emails from a limited set of lists. For example: p8xtmy67z162x8827pk3hy3czn_dev.ponymail.apache.org could become p8xtmy67z162x8827pk3hy3czn_dev.ponymail_ where the trailing '_' means '.apache.org' (for this installation) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
