sebbASF commented on pull request #517: URL: https://github.com/apache/incubator-ponymail/pull/517#issuecomment-691349802
On further reflection I think it's not worth normalising the From lines fully. The most common case would be covered. However, I think it's vital that we do not implement the a new generator until we are sure that all issues have been addressed. Every change to the algorithm reduces Permalink stability. The latest changes to the PR dropped the LID from the hash, so the lid needs to be provided separately in order to create a unique Permalink. One way to do this would be to append the lid as below: p8xtmy67z162x8827pk3hy3czn_dev.ponymail.apache.org There is no need for the enclosing < and >, and _ is better than @ as a separator. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
