codings-dan commented on pull request #614: URL: https://github.com/apache/ratis/pull/614#issuecomment-1056860682
> @codings-dan , let's focus on changing proto and AdminImpl here. See https://issues.apache.org/jira/secure/attachment/13040593/614_review.patch > > * We need to keep in mind that old peers can become a listener. Similarly, old listeners can become a peer. > * We should not remove the old PeerConfiguration constructor since listeners are optional. @szetszwo Thanks for reminding me, I fell into a misunderstanding that listener and peer still maintain their original identities in new conf and will not convert to each other. So, before and after setConfiguration, they can be converted to each other, so what is the difference between learner and listener? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
