codings-dan commented on a change in pull request #614:
URL: https://github.com/apache/ratis/pull/614#discussion_r817646808
##########
File path:
ratis-common/src/main/java/org/apache/ratis/protocol/SetConfigurationRequest.java
##########
@@ -24,18 +24,30 @@
public class SetConfigurationRequest extends RaftClientRequest {
private final List<RaftPeer> peers;
+ private final List<RaftPeer> listeners;
public SetConfigurationRequest(ClientId clientId, RaftPeerId serverId,
RaftGroupId groupId, long callId, List<RaftPeer> peers) {
+ this(clientId, serverId, groupId, callId, peers, Collections.emptyList());
+ }
Review comment:
I recommend keeping this constructor as well for forward compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]