inomp3042 commented on code in PR #638:
URL: https://github.com/apache/ratis/pull/638#discussion_r861598340
##########
ratis-server-api/src/main/java/org/apache/ratis/statemachine/StateMachine.java:
##########
@@ -204,10 +205,11 @@ interface LeaderEventApi {
* This notification is based on "raft.server.rpc.slowness.timeout".
*
* @param roleInfoProto information about the current node role and rpc
delay information
+ * @param followerInfo information about slow follower
*
* @see
org.apache.ratis.server.RaftServerConfigKeys.Rpc#SLOWNESS_TIMEOUT_KEY
*/
- default void notifyFollowerSlowness(RoleInfoProto roleInfoProto) {}
+ default void notifyFollowerSlowness(RoleInfoProto roleInfoProto,
FollowerInfo followerInfo) {}
Review Comment:
I'm just wondering about your comment.
FollowerInfo is in ratis-server-api project's leader package, and
`notifyFollowerSlowness`, which is in `LeaderEventApi`, is called on a leader.
Even though it is in this case, should it not appear in the StateMachine API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
