szetszwo commented on code in PR #638:
URL: https://github.com/apache/ratis/pull/638#discussion_r862749237
##########
ratis-server/src/test/java/org/apache/ratis/statemachine/SimpleStateMachine4Testing.java:
##########
@@ -416,9 +417,15 @@ public void unblockFlushStateMachineData() {
}
@Override
- public void notifyFollowerSlowness(RoleInfoProto roleInfoProto) {
- LOG.info("{}: notifySlowness {}, {}", this, groupId, roleInfoProto);
- slownessInfo = roleInfoProto;
+ public void notifyFollowerSlowness(RoleInfoProto leaderInfo) {
+ LOG.info("{}: notifySlowness {}, {}", this, groupId, leaderInfo);
+ slownessInfo = leaderInfo;
+ }
Review Comment:
Please remove notifyFollowerSlowness(RoleInfoProto leaderInfo) since it
already has notifyFollowerSlowness(RoleInfoProto leaderInfo, RaftPeer
slowFollower). Implementations only have to override one of the methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
