inomp3042 commented on code in PR #638:
URL: https://github.com/apache/ratis/pull/638#discussion_r862606041
##########
ratis-server-api/src/main/java/org/apache/ratis/statemachine/StateMachine.java:
##########
@@ -204,10 +205,11 @@ interface LeaderEventApi {
* This notification is based on "raft.server.rpc.slowness.timeout".
*
* @param roleInfoProto information about the current node role and rpc
delay information
+ * @param followerInfo information about slow follower
*
* @see
org.apache.ratis.server.RaftServerConfigKeys.Rpc#SLOWNESS_TIMEOUT_KEY
*/
- default void notifyFollowerSlowness(RoleInfoProto roleInfoProto) {}
+ default void notifyFollowerSlowness(RoleInfoProto roleInfoProto,
FollowerInfo followerInfo) {}
Review Comment:
> Sorry, this idea is incorrect. The RoleInfoProto is for leader. We should
not change it.
How about adding a RaftPeerId for the slow follower?
I see. I think that RaftPeer is better than RaftPeerId. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
