codings-dan commented on code in PR #682:
URL: https://github.com/apache/ratis/pull/682#discussion_r923269477
##########
ratis-common/src/main/java/org/apache/ratis/protocol/SetConfigurationRequest.java:
##########
@@ -29,25 +29,41 @@ public class SetConfigurationRequest extends
RaftClientRequest {
public enum Mode {
SET_UNCONDITIONALLY,
- ADD
+ ADD,
+ CAS
}
public static final class Arguments {
private final List<RaftPeer> serversInNewConf;
private final List<RaftPeer> listenersInNewConf;
+ private final List<RaftPeer> serversInCurConf;
+ private final List<RaftPeer> listenersInCurConf;
private final Mode mode;
- private Arguments(List<RaftPeer> serversInNewConf, List<RaftPeer>
listenersInNewConf,Mode mode) {
+ private Arguments(List<RaftPeer> serversInNewConf, List<RaftPeer>
listenersInNewConf, Mode mode) {
+ this(serversInNewConf, listenersInNewConf, Collections.emptyList(),
Collections.emptyList(), mode);
+ }
Review Comment:
done
##########
ratis-common/src/main/java/org/apache/ratis/protocol/SetConfigurationRequest.java:
##########
@@ -59,6 +75,14 @@ public List<RaftPeer>
getPeersInNewConf(RaftProtos.RaftPeerRole role) {
}
}
+ public List<RaftPeer> getListenersInCurConf() {
+ return listenersInCurConf;
+ }
+
+ public List<RaftPeer> getServersInCurConf() {
+ return serversInCurConf;
+ }
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
