codings-dan commented on code in PR #682:
URL: https://github.com/apache/ratis/pull/682#discussion_r923269763
##########
ratis-server/src/test/java/org/apache/ratis/server/impl/RaftReconfigurationBaseTest.java:
##########
@@ -216,6 +217,43 @@ private void runTestSetConfigurationInAddMode(CLUSTER
cluster) throws Exception
cluster.close();
}
+ @Test
+ public void testSetConfigurationInCasMode() throws Exception {
+ runWithNewCluster(2, this::runTestSetConfigurationInCasMode);
+ }
+
+ private void runTestSetConfigurationInCasMode(CLUSTER cluster) throws
Exception {
+ final RaftServer.Division leader = RaftTestUtil.waitForLeader(cluster);
+ List<RaftPeer> oldPeers = cluster.getPeers();
+
+ PeerChanges change = cluster.addNewPeers(1, true);
+ List<RaftPeer> peers = Arrays.asList(change.allPeersInNewConf);
+
+ try (final RaftClient client = cluster.createClient(leader.getId())) {
+ for (int i = 0; i < 10; i++) {
+ RaftClientReply reply = client.io().send(new SimpleMessage("m" + i));
+ Assert.assertTrue(reply.isSuccess());
+ }
+
+ testFailureCase("Can't set configuration in CAS mode ",
+ () ->
client.admin().setConfiguration(SetConfigurationRequest.Arguments.newBuilder()
+ .setServersInNewConf(peers)
+ .setServersInCurConf(peers)
+ .setMode(SetConfigurationRequest.Mode.CAS)
+ .build()), SetConfigurationCasModeException.class);
+
+ RaftClientReply reply = client.admin().setConfiguration(
+ SetConfigurationRequest.Arguments.newBuilder()
+ .setServersInNewConf(peers)
+ .setServersInCurConf(oldPeers)
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
