codings-dan commented on code in PR #682:
URL: https://github.com/apache/ratis/pull/682#discussion_r923272753
##########
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java:
##########
@@ -1108,6 +1109,17 @@ public CompletableFuture<RaftClientReply>
setConfigurationAsync(SetConfiguration
if (arguments.getMode() == SetConfigurationRequest.Mode.ADD) {
serversInNewConf = add(RaftPeerRole.FOLLOWER, current, arguments);
listenersInNewConf = add(RaftPeerRole.LISTENER, current, arguments);
+ } else if (arguments.getMode() == SetConfigurationRequest.Mode.CAS) {
+ List<RaftPeer> serversInCurConf = arguments.getServersInCurConf();
+ List<RaftPeer> listenersInCurConf = arguments.getListenersInCurConf();
+ if (serversInCurConf.equals(current.getAllPeers(RaftPeerRole.FOLLOWER))
Review Comment:
Good catch! I have added the method and changed the related code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
