jiacheliu3 commented on code in PR #733:
URL: https://github.com/apache/ratis/pull/733#discussion_r962138194
##########
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerProxy.java:
##########
@@ -407,6 +426,7 @@ public void close() {
try {
getServerRpc().close();
} catch(IOException ignored) {
+ // TODO(jiacheng): transition state to EXCEPTION here?
Review Comment:
In the existing code I don't think we transition to EXCEPTION very often. In
many places like this, we might wanna transition the state and expose the
exception to the outside. And the Ratis user can just observe the `RaftServer`
lifecycle and choose to restart the RaftServer or do whatever else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
