jiacheliu3 commented on code in PR #733:
URL: https://github.com/apache/ratis/pull/733#discussion_r962139553


##########
ratis-common/src/main/java/org/apache/ratis/util/Daemon.java:
##########
@@ -37,4 +57,32 @@ public Daemon(Runnable runnable, String name) {
     super(runnable);
     this.setName(name);
   }
+
+  public Daemon(Runnable runnable, String name, ErrorRecorded server) {

Review Comment:
   I ignored `Daemon` threads created in `JvmPauseMonitor` and 
`TimeoutScheduler` because my intuition is even if they crash, the RaftServer 
can still live.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to