jiacheliu3 commented on code in PR #733:
URL: https://github.com/apache/ratis/pull/733#discussion_r962138969
##########
ratis-server/src/main/java/org/apache/ratis/server/impl/LeaderElection.java:
##########
@@ -138,6 +138,7 @@ static class Executor {
Executor(Object name, int size) {
Preconditions.assertTrue(size > 0);
+ // TODO(jiacheng): intentionally ignoring the server ref here? Why?
executor = Executors.newFixedThreadPool(size, r -> new Daemon(r, name +
"-" + count.incrementAndGet()));
Review Comment:
Intentionally not passing the `RaftServerImpl` reference to the Daemon
thread so a dead thread doesn't set the RaftServerImpl state to EXCEPTION. My
intuition is that a failed prevote doesn't matter that much because it will be
retried. Could someone confirm?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
