jiacheliu3 commented on PR #733: URL: https://github.com/apache/ratis/pull/733#issuecomment-1246442293
> @jiacheliu3 , thanks for the update! This change becomes big and involves many files. Could you split it into two pull requests? > > 1. Add a Daemon.Builder. > 2. Support UncaughtExceptionHandler. > > Some comments inlined but I have not checked all the changes. A separate PR https://github.com/apache/ratis/pull/747 is created to segregate the `Daemon.Builder` part of changes. All relevant comments will be addressed in that PR and I'll click `Resolve comment` on this one after that. Sorry about the inconvenience in review, if any. Then this PR will be rebased on #747 and only takes care of adding the `UncaughtExceptionHandler`. I will reuse this PR so all comment history is kept intact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
