szetszwo commented on code in PR #745:
URL: https://github.com/apache/ratis/pull/745#discussion_r969772219
##########
ratis-server/src/main/java/org/apache/ratis/server/leader/LogAppenderBase.java:
##########
@@ -158,6 +158,11 @@ private TermIndex getPrevious(long nextIndex) {
}
}
+ final long raftLogLastPurgedIndex = getRaftLog().getStartIndex() - 1;
+ if (raftLogLastPurgedIndex == previousIndex) {
+ return TermIndex.valueOf(server.getInfo().getCurrentTerm(),
raftLogLastPurgedIndex);
Review Comment:
@Xushaohong , you are right that the term may be skipped so that returning
`currentTerm - 1 ` is incorrect. Good catch! How about the following?
```java
if (getRaftLog().getStartIndex() == nextIndex) {
if (nextIndex > leaderState.getTermBeginIndex()) {
return TermIndex.valueOf(server.getInfo().getCurrentTerm(),
previousIndex);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
