Xushaohong commented on code in PR #745:
URL: https://github.com/apache/ratis/pull/745#discussion_r970372341


##########
ratis-server/src/main/java/org/apache/ratis/server/leader/LogAppenderBase.java:
##########
@@ -158,6 +158,11 @@ private TermIndex getPrevious(long nextIndex) {
       }
     }
 
+    final long raftLogLastPurgedIndex = getRaftLog().getStartIndex() - 1;
+    if (raftLogLastPurgedIndex == previousIndex) {
+      return TermIndex.valueOf(server.getInfo().getCurrentTerm(), 
raftLogLastPurgedIndex);

Review Comment:
   I checked the log again. 
   
   Leader A's beginIndex is  **term 17 for 3407894** , raft log begin index is 
**log_3402406-3407893**
   
   Follower B's snapshotIndex is (t:9, i:3402405).
   
   So, this is the case nextIndex < leaderState.getTermBeginIndex. We are both 
wrong lol. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to