szetszwo commented on code in PR #745:
URL: https://github.com/apache/ratis/pull/745#discussion_r971644590
##########
ratis-server/src/main/java/org/apache/ratis/server/leader/LogAppenderBase.java:
##########
@@ -158,6 +158,11 @@ private TermIndex getPrevious(long nextIndex) {
}
}
+ final long raftLogLastPurgedIndex = getRaftLog().getStartIndex() - 1;
+ if (raftLogLastPurgedIndex == previousIndex) {
+ return TermIndex.valueOf(server.getInfo().getCurrentTerm(),
raftLogLastPurgedIndex);
Review Comment:
When A sent `notifyInstallSnapshot`, did B install a snapshot by itself?
> Since A's raft log.startIndex had not changed, A will still try to append
the log starting from 3402406, which caused the loop.
This looks correct -- the Leader A was sending heartbeats. It is supposed
to work like that -- A will keep sending heartbeats until B has installed a
snapshot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
