jiacheliu3 commented on code in PR #733:
URL: https://github.com/apache/ratis/pull/733#discussion_r971514246
##########
ratis-common/src/main/java/org/apache/ratis/util/Daemon.java:
##########
@@ -49,6 +60,11 @@ public Builder setRunnable(Runnable runnable) {
return this;
}
+ public Builder setUncaughtExceptionHandler(UncaughtExceptionHandler
exceptionHandler) {
Review Comment:
Not sure how much UT would be necessary. If necessary, I'll try writing
something similar to RaftStateMachineExceptionTests using a MiniRaftCluster
which creates a RaftServer with my user defined UncaughtExceptionHandler, and
when I throw an exception internally, check if the handler is able to catch
that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
