jiacheliu3 commented on code in PR #733:
URL: https://github.com/apache/ratis/pull/733#discussion_r974350238
##########
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerProxy.java:
##########
@@ -196,9 +197,11 @@ String toString(RaftGroupId groupId,
CompletableFuture<RaftServerImpl> f) {
private final ExecutorService executor;
private final JvmPauseMonitor pauseMonitor;
+ @Nullable
Review Comment:
Actually I figure a `null` here is fine.
[doc](https://docs.oracle.com/javase/8/docs/api/java/lang/Thread.html#Thread-java.lang.ThreadGroup-java.lang.Runnable-)
specifies that is the `ThreadGroup` arg is null, the current thread's group is
inherited. That behavior can be better than we guess a default here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
