jiacheliu3 commented on code in PR #733:
URL: https://github.com/apache/ratis/pull/733#discussion_r973118085
##########
ratis-server/src/main/java/org/apache/ratis/server/leader/LogAppenderDaemon.java:
##########
@@ -44,11 +46,17 @@ class LogAppenderDaemon {
private final LogAppender logAppender;
- LogAppenderDaemon(LogAppender logAppender) {
+ LogAppenderDaemon(LogAppender logAppender, RaftServer.Division server) {
Review Comment:
That is possible but I will need to pass in the `ThreadGroup` from
`RaftServerImpl`
[here](https://github.com/apache/ratis/blob/8fbe434efad64436e5505f5a03a4ef048a425a0a/ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java#L245)
and essentially modify the signature on [this
interface](https://github.com/apache/ratis/blob/8fbe434efad64436e5505f5a03a4ef048a425a0a/ratis-server-api/src/main/java/org/apache/ratis/server/ServerFactory.java#L37).
So which one do you prefer @codings-dan :
Option 1: Update the interface `ServerFactory.newLogAppender()` to pass in
`ThreadGroup`. If this interface is not public-facing then I'll just do that.
Option 2: Do the cast here as the code currently shows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
