codings-dan commented on code in PR #733:
URL: https://github.com/apache/ratis/pull/733#discussion_r973010503
##########
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerProxy.java:
##########
@@ -379,6 +383,10 @@ public LifeCycle.State getLifeCycleState() {
return lifeCycle.getCurrentState();
}
+ public ThreadGroup getThreadGroup() {
+ return this.threadGroup;
Review Comment:
remove `this`
##########
ratis-server/src/main/java/org/apache/ratis/server/leader/LogAppenderDaemon.java:
##########
@@ -44,11 +46,17 @@ class LogAppenderDaemon {
private final LogAppender logAppender;
- LogAppenderDaemon(LogAppender logAppender) {
+ LogAppenderDaemon(LogAppender logAppender, RaftServer.Division server) {
Review Comment:
Is it possible to pass in a `ThreadGroup` here instead of passing in a
`RaftServer.Division`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
