adoroszlai commented on code in PR #1227:
URL: https://github.com/apache/ratis/pull/1227#discussion_r1985372705
##########
pom.xml:
##########
@@ -174,7 +174,7 @@
<maven-pdf-plugin.version>1.6.1</maven-pdf-plugin.version>
<maven-remote-resources-plugin.version>3.3.0</maven-remote-resources-plugin.version>
<maven-shade-plugin.version>3.6.0</maven-shade-plugin.version>
- <maven-surefire-plugin.version>3.0.0-M4</maven-surefire-plugin.version>
+ <maven-surefire-plugin.version>3.0.0-M9</maven-surefire-plugin.version>
Review Comment:
I tried updating surefire to 3.5.2, but had some problems:
```
Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:3.5.2:test (default-test) on
project ratis-docs: groups/excludedGroups require TestNG, JUnit48+ or JUnit 5
(a specific engine required on classpath) on project test classpath
Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:3.5.2:test (default-test) on
project ratis-proto: groups/excludedGroups require TestNG, JUnit48+ or JUnit 5
(a specific engine required on classpath) on project test classpath
```
These modules have `skipTests=true`, so I don't understand why surefire
wants to run tests. Also tried with `maven.test.skip=true`, which should even
skip test compilation, but the problem still happened.
It would be great if you can make it work.
https://github.com/adoroszlai/ratis/commit/d53a586d3ccae780c152841296e5df9314d4113d
https://github.com/adoroszlai/ratis/actions/runs/13670191390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
