adoroszlai commented on code in PR #1227:
URL: https://github.com/apache/ratis/pull/1227#discussion_r1988390235
##########
pom.xml:
##########
@@ -174,7 +174,7 @@
<maven-pdf-plugin.version>1.6.1</maven-pdf-plugin.version>
<maven-remote-resources-plugin.version>3.3.0</maven-remote-resources-plugin.version>
<maven-shade-plugin.version>3.6.0</maven-shade-plugin.version>
- <maven-surefire-plugin.version>3.0.0-M4</maven-surefire-plugin.version>
+ <maven-surefire-plugin.version>3.0.0-M9</maven-surefire-plugin.version>
Review Comment:
Please do not disable tests.
1. Trigger [repeated
run](https://github.com/slfan1989/ratis/actions/workflows/repeat-test.yaml) to
confirm flakiness and establish failure rate.
2. Create Jira issue to record the problem.
3. Mark test as `@Flaky`, referencing the Jira issue.
`@Flaky` tests are repeated automatically in CI.
Note, it does not help for tests failing due to leaks, as state of leak
detector is not reset between retries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
