adoroszlai commented on code in PR #1227:
URL: https://github.com/apache/ratis/pull/1227#discussion_r1985480961
##########
pom.xml:
##########
@@ -174,7 +174,7 @@
<maven-pdf-plugin.version>1.6.1</maven-pdf-plugin.version>
<maven-remote-resources-plugin.version>3.3.0</maven-remote-resources-plugin.version>
<maven-shade-plugin.version>3.6.0</maven-shade-plugin.version>
- <maven-surefire-plugin.version>3.0.0-M4</maven-surefire-plugin.version>
+ <maven-surefire-plugin.version>3.0.0-M9</maven-surefire-plugin.version>
Review Comment:
The error says it's related to using `excludedGroups`:
```
groups/excludedGroups require TestNG, JUnit48+ or JUnit 5 (a specific engine
required on classpath) on project test classpath
```
which is set in CI:
https://github.com/apache/ratis/blob/d740e513555a3c4bbf26cab061bca5ff63bb1859/pom.xml#L1122
This should not happen with
[`skipTests`](https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#skiptests),
which we set for `ratis-docs` here:
https://github.com/apache/ratis/blob/d740e513555a3c4bbf26cab061bca5ff63bb1859/ratis-docs/pom.xml#L31-L32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
