[
https://issues.apache.org/jira/browse/RATIS-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18066131#comment-18066131
]
Attila Doroszlai commented on RATIS-2338:
-----------------------------------------
This change makes the release non-reproducible, because jars now depend on the
Git repo URL. Staged jars point to {{onesizefitsquorum/ratis}}, not
{{apache/ratis}}.
{code}
$ git clone https://github.com/apache/ratis.git
$ cd ratis
$ git checkout ratis-3.2.2-rc2
$ mvn clean package artifact:compare
-Dreference.repo=https://repository.apache.org/content/repositories/staging/
...
[ERROR] size mismatch ratis-docs-3.2.2.jar: investigate with diffoscope
ratis-docs/target/reference/org.apache.ratis/ratis-docs-3.2.2.jar
ratis-docs/target/ratis-docs-3.2.2.jar
[ERROR] [Reproducible Builds] rebuild comparison result: 2 files match, 1 differ
[ERROR] saved to
ratis-docs/target/ratis-docs-3.2.2.buildcompare
[ERROR] [Reproducible Builds] to analyze the differences, see diffoscope
instructions in ratis-docs/target/ratis-docs-3.2.2.buildcompare
[ERROR] see also
https://maven.apache.org/guides/mini/guide-reproducible-builds.html
...
[INFO] BUILD FAILURE
$ diffoscope ratis-docs/target/reference/org.apache.ratis/ratis-docs-3.2.2.jar
ratis-docs/target/ratis-docs-3.2.2.jar
--- ratis-docs/target/reference/org.apache.ratis/ratis-docs-3.2.2.jar
+++ ratis-docs/target/ratis-docs-3.2.2.jar
├── zipinfo {}
│ @@ -1,13 +1,13 @@
│ -Zip file size: 7186 bytes, number of entries: 11
│ +Zip file size: 7175 bytes, number of entries: 11
│ drwxr-xr-x 2.0 unx 0 b- stor 26-Mar-12 15:19 META-INF/
│ -rw-r--r-- 2.0 unx 349 b- defN 26-Mar-12 15:19 META-INF/MANIFEST.MF
│ drwxr-xr-x 2.0 unx 0 b- stor 26-Mar-12 15:19 META-INF/maven/
│ drwxr-xr-x 2.0 unx 0 b- stor 26-Mar-12 15:19
META-INF/maven/org.apache.ratis/
│ drwxr-xr-x 2.0 unx 0 b- stor 26-Mar-12 15:19
META-INF/maven/org.apache.ratis/ratis-docs/
│ -rw-r--r-- 2.0 unx 276 b- defN 26-Mar-12 15:19 META-INF/DEPENDENCIES
│ -rw-r--r-- 2.0 unx 11358 b- defN 26-Mar-12 15:19 META-INF/LICENSE
│ -rw-r--r-- 2.0 unx 181 b- defN 26-Mar-12 15:19 META-INF/NOTICE
│ --rw-r--r-- 2.0 unx 932 b- defN 26-Mar-12 15:19 ratis-version.properties
│ +-rw-r--r-- 2.0 unx 921 b- defN 26-Mar-12 15:19 ratis-version.properties
│ -rw-r--r-- 2.0 unx 1602 b- defN 26-Mar-12 15:19
META-INF/maven/org.apache.ratis/ratis-docs/pom.xml
│ -rw-r--r-- 2.0 unx 61 b- defN 26-Mar-12 15:19
META-INF/maven/org.apache.ratis/ratis-docs/pom.properties
│ -11 files, 14759 bytes uncompressed, 5724 bytes compressed: 61.2%
│ +11 files, 14748 bytes uncompressed, 5713 bytes compressed: 61.3%
├── ratis-version.properties
│ @@ -13,9 +13,9 @@
│ # distributed under the License is distributed on an "AS IS" BASIS,
│ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
│ # See the License for the specific language governing permissions and
│ # limitations under the License.
│ #
│ name=Apache Ratis Documentation
│ version=3.2.2
│ [email protected]:onesizefitsquorum/ratis.git
│ [email protected]:apache/ratis.git
│ revision=550d926cc78039504ab32d078e06bac6681eb3dd
{code}
[~tanxinyu], I think we could mitigate the problem by pointing the remote
{{origin}} to {{apache/ratis}}, not to one's own fork.
> Print version info when starting a server
> -----------------------------------------
>
> Key: RATIS-2338
> URL: https://issues.apache.org/jira/browse/RATIS-2338
> Project: Ratis
> Issue Type: Improvement
> Components: server
> Reporter: Tsz-wo Sze
> Assignee: Tsz-wo Sze
> Priority: Major
> Fix For: 3.2.1
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> We are already using hadoops:version-info to generate
> ratis-version.properties files. This JIRA is to print the version info when
> starting a server.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
