[
https://issues.apache.org/jira/browse/RATIS-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18066383#comment-18066383
]
Xinyu Tan commented on RATIS-2338:
----------------------------------
Hi, [~adoroszlai] and [~szetszwo]
Thanks for point this out!
Regarding the root cause, we cannot simply rename the {{origin}} remote to the
official Apache repo to solve this. The current {{make_rc.sh}} script (see
[line
152|https://github.com/apache/ratis/blob/master/dev-support/make_rc.sh#L152])
already explicitly assumes and verifies that {{apache}} is the official remote,
separate from the user's {{{}origin{}}}.
To ensure reproducible builds without forcing users to change their local Git
setup, I have two proposals: # {*}Override via CLI in {{make_rc.sh}}{*}: We can
explicitly pass the official URL during the Maven build in the script:
{{mvn clean install -Dversion-info.scm.uri=https://github.com ...}}
This overrides whatever is in the local {{{}.git/config{}}}.
# {*}Modify Maven Configuration{*}: We could hardcode the official Apache URL
in the {{pom.xml}} release profile, or simply remove the {{url}} field from
{{ratis-version.properties}} entirely, since the {{revision}} (commit hash) is
already sufficient for audit purposes.
Which approach do you think is better for the long term?
----
> Print version info when starting a server
> -----------------------------------------
>
> Key: RATIS-2338
> URL: https://issues.apache.org/jira/browse/RATIS-2338
> Project: Ratis
> Issue Type: Improvement
> Components: server
> Reporter: Tsz-wo Sze
> Assignee: Tsz-wo Sze
> Priority: Major
> Fix For: 3.2.1
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> We are already using hadoops:version-info to generate
> ratis-version.properties files. This JIRA is to print the version info when
> starting a server.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
