ss77892 commented on code in PR #1538:
URL: https://github.com/apache/ratis/pull/1538#discussion_r3699727522
##########
ratis-netty/src/main/java/org/apache/ratis/netty/server/NettyRpcService.java:
##########
@@ -116,6 +136,11 @@ protected void initChannel(SocketChannel ch) {
}
};
+ this.requestExecutor = ConcurrentUtils.newThreadPoolWithMax(
Review Comment:
So, it's still a single worker pool (corePoolSize is 0). But instead of
using TCP backpressure, we are pushing everything to the unlimited queue and
creating pressure on the memory. Moreover, previously, Netty’s worker
EventLoops handled connection shards independently, so a blocked request
delayed only that shard’s RPCs. The new default single request worker queues
all inbound RPCs, including heartbeats, so one slow request can delay
heartbeats and trigger leader election.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
