spacemonkd commented on code in PR #1538:
URL: https://github.com/apache/ratis/pull/1538#discussion_r3700944214
##########
ratis-netty/src/main/java/org/apache/ratis/netty/server/NettyRpcService.java:
##########
@@ -116,6 +136,11 @@ protected void initChannel(SocketChannel ch) {
}
};
+ this.requestExecutor = ConcurrentUtils.newThreadPoolWithMax(
Review Comment:
> Another thing: we have ThreadPoolExecutor with corePoolSize=0 and
unbounded queue.
the corePoolSize=0 + unbounded-queue cached pool is effectively
single-threaded, however this PR now defaults to a fixed pool
(corePoolSize=32), so inbound RPCs including heartbeats are no longer
serialized behind one slow request.
So I have effectively switched back to the earlier behaviour for the time
being.
Let's avoid making this patch bigger and address separately as right now
this is effective the previous behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
