ss77892 commented on code in PR #1538:
URL: https://github.com/apache/ratis/pull/1538#discussion_r3700686912
##########
ratis-netty/src/main/java/org/apache/ratis/netty/server/NettyRpcService.java:
##########
@@ -155,6 +192,7 @@ public void startImpl() throws IOException {
@Override
public void closeImpl() throws IOException {
+ ConcurrentUtils.shutdownAndWait(requestExecutor);
Review Comment:
shutdownAndWait is running with a 1-day timeout, and if the executor is
stuck, we won't close the channel and event-loop group for a day, would we?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
