[
https://issues.apache.org/jira/browse/RATIS-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16240803#comment-16240803
]
Tsz Wo Nicholas Sze commented on RATIS-132:
-------------------------------------------
[~elek], thanks a lot for fixing this. Your solution sounds good. Will test it
(BTW, I moved your explanation of the patch to a comment so that we can keep
the description short.)
> Support simple 'mvn clean compile' command (move shading before the compile
> phase)
> -----------------------------------------------------------------------------------
>
> Key: RATIS-132
> URL: https://issues.apache.org/jira/browse/RATIS-132
> Project: Ratis
> Issue Type: Bug
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Trivial
> Attachments: RATIS-132.001.patch
>
>
> The current situation is described in the BUILDING.md:
> {code}
> When building Ratis the first time, shaded files need to be generated by the
> following command:
> ```
> $ mvn package -DskipTests
> ```
> After that, `mvn compile` or `mvn test` can be used as normal.
> For example, we may run the basic tests by
> ```
> {code}
> In short: the shading phase is bound to the 'package' maven phase, therefore
> we can't use 'mvn clean install' just 'mvn clean package' because the package
> phase should be done before the compilation of ratis-proto-shaded.
> This blocks the nightly build as yetus uses one 'mvn clean compile' or 'mvn
> clean test-compile' without invoking the package phase.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
