[
https://issues.apache.org/jira/browse/RATIS-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16240886#comment-16240886
]
Tsz Wo Nicholas Sze commented on RATIS-132:
-------------------------------------------
Just have tried the patch. It fails when I run {{mvn test}} without clean.
More details below:
# mvn clean
# mvn test -Dtest=TestFileStoreWithNetty
Running it 1st time after clean, it compiles protobuf, shades and successfully
runs the test.
# mvn test -Dtest=TestFileStoreWithNetty
Running it 2nd time after clean, it fails with following
{code}
2017-11-06 12:53:39,349 TRACE util.FileUtils (LogUtils.java:runAndLog(55)) -
Successfully ran Files.createDirectories
/Users/szetszwo/hadoop/r2/ratis-examples/target/test/data/f848208a/filestore/s0
2017-11-06 12:53:39,350 WARN impl.RaftServerProxy
(JavaUtils.java:attempt(129)) - FAILED new RaftServerProxy attempt #1/5:
java.lang.BootstrapMethodError: java.lang.NoClassDefFoundError:
org/apache/ratis/shaded/proto/RaftProtos$LogEntryProto, sleep 500ms and then
retry.
java.lang.BootstrapMethodError: java.lang.NoClassDefFoundError:
org/apache/ratis/shaded/proto/RaftProtos$LogEntryProto
{code}
> Support simple 'mvn clean compile' command (move shading before the compile
> phase)
> -----------------------------------------------------------------------------------
>
> Key: RATIS-132
> URL: https://issues.apache.org/jira/browse/RATIS-132
> Project: Ratis
> Issue Type: Bug
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Trivial
> Attachments: RATIS-132.001.patch
>
>
> The current situation is described in the BUILDING.md:
> {code}
> When building Ratis the first time, shaded files need to be generated by the
> following command:
> ```
> $ mvn package -DskipTests
> ```
> After that, `mvn compile` or `mvn test` can be used as normal.
> For example, we may run the basic tests by
> ```
> {code}
> In short: the shading phase is bound to the 'package' maven phase, therefore
> we can't use 'mvn clean install' just 'mvn clean package' because the package
> phase should be done before the compilation of ratis-proto-shaded.
> This blocks the nightly build as yetus uses one 'mvn clean compile' or 'mvn
> clean test-compile' without invoking the package phase.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
